Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): formula offscreen #1252

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix(sheet): formula offscreen #1252

merged 1 commit into from
Jan 25, 2024

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Jan 25, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1070

@DR-Univer DR-Univer added bug Something isn't working qa:untested This PR is ready to be tested and removed bug Something isn't working labels Jan 25, 2024
Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

7.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

github-actions bot commented Jan 25, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (39d23f1) 29.62% compared to head (e485d5b) 29.62%.
Report is 2 commits behind head on dev.

Files Patch % Lines
packages/engine-render/src/engine.ts 0.00% 8 Missing ⚠️
...c/components/docs/text-selection-render-manager.ts 0.00% 6 Missing ⚠️
...ne-render/src/components/sheets/extensions/font.ts 0.00% 1 Missing ⚠️
packages/engine-render/src/thin-engine.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1252      +/-   ##
==========================================
- Coverage   29.62%   29.62%   -0.01%     
==========================================
  Files         829      829              
  Lines       46865    46874       +9     
  Branches     9591     9591              
==========================================
  Hits        13885    13885              
- Misses      28765    28774       +9     
  Partials     4215     4215              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Jan 25, 2024
@DR-Univer DR-Univer merged commit 518368f into dev Jan 25, 2024
10 of 11 checks passed
@DR-Univer DR-Univer deleted the fix-formula-selection-off branch January 25, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 公式选择选区时,松开鼠标后滑动仍可以继续修改选区
2 participants