Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename isAutoHeight to ia and change its TS type #1210

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

Jocs
Copy link
Contributor

@Jocs Jocs commented Jan 22, 2024

…umber

  • I am sure that the code is update-to-date with the dev branch.

close #1163

Copy link

sonarcloud bot commented Jan 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

4.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

github-actions bot commented Jan 22, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ff8cfe7) 29.51% compared to head (6abc026) 29.51%.

Files Patch % Lines
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 0 Missing and 3 partials ⚠️
packages/core/src/sheets/row-manager.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1210   +/-   ##
=======================================
  Coverage   29.51%   29.51%           
=======================================
  Files         828      828           
  Lines       46982    46982           
  Branches     9629     9629           
=======================================
  Hits        13868    13868           
  Misses      28903    28903           
  Partials     4211     4211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jocs
Copy link
Contributor Author

Jocs commented Jan 22, 2024

@wzhudev @DR-Univer @jikkai 涉及到 breaking change,我们发布的时候可能需要给一些提醒?

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@wzhudev @DR-Univer @jikkai When it comes to breaking changes, we may need to give some reminders when we release them?

@wzhudev
Copy link
Member

wzhudev commented Jan 22, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@wzhudev @DR-Univer @jikkai When it comes to breaking changes, we may need to give some reminders when we release them?

一般是要在 commit message 里写上 BREAKING_CHANGE:

@jikkai Contributing guide 需要说明一下

@Jocs Jocs marked this pull request as ready for review January 22, 2024 09:10
@wzhudev wzhudev merged commit 3c67252 into dev Jan 24, 2024
9 of 10 checks passed
@wzhudev wzhudev deleted the refactor/is-auto-height branch January 24, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename isAutoHeight to ia and it's TS type
3 participants