Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change insert/delete row/col mutation implement #1203

Merged
merged 6 commits into from
Jan 24, 2024

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Jan 21, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #

Copy link

github-actions bot commented Jan 21, 2024

View Deployment

#7628515594

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
0.0% Coverage on New Code
2.3% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (f9430de) 29.51% compared to head (17dfc79) 29.53%.
Report is 12 commits behind head on dev.

Files Patch % Lines
packages/core/src/shared/object-matrix.ts 0.00% 33 Missing ⚠️
...ommands/commands/insert-range-move-down.command.ts 46.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1203      +/-   ##
==========================================
+ Coverage   29.51%   29.53%   +0.01%     
==========================================
  Files         828      829       +1     
  Lines       46942    46797     -145     
  Branches     9622     9557      -65     
==========================================
- Hits        13854    13820      -34     
+ Misses      28884    28762     -122     
- Partials     4204     4215      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev
Copy link
Member

wzhudev commented Jan 24, 2024

View Deployment

#7628515594

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪 Still cooking, please come back later 🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟

This is still building. cc @jikkai

@wzhudev wzhudev merged commit 73c22b2 into dev Jan 24, 2024
10 checks passed
@wzhudev wzhudev deleted the yuhongz/feat-insertdeleterowcol branch January 24, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants