Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header): fix selected range not changed when clicking menu #1073

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 10, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1068
close #1076

  1. Univer will now selected the column if the context menu is not triggerred in the selected range
  2. Row height & column width has a minimum value of 2px

@wzhudev wzhudev requested a review from jikkai as a code owner January 10, 2024 00:29
@wzhudev wzhudev added the qa:untested This PR is ready to be tested label Jan 10, 2024
Copy link

github-actions bot commented Jan 10, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (6f71597) 28.88% compared to head (e8b0aa7) 28.89%.
Report is 6 commits behind head on dev.

Files Patch % Lines
...heets-ui/src/controllers/header-menu.controller.ts 0.00% 9 Missing and 3 partials ⚠️
...i/src/components/menu-item-input/MenuItemInput.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1073   +/-   ##
=======================================
  Coverage   28.88%   28.89%           
=======================================
  Files         747      747           
  Lines       44187    44182    -5     
  Branches     9139     9133    -6     
=======================================
+ Hits        12764    12766    +2     
+ Misses      27463    27456    -7     
  Partials     3960     3960           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev force-pushed the wzhudev/fix-headermenu-range branch from 82b05e0 to 5976ad8 Compare January 10, 2024 00:47
@zhaolixin7
Copy link

@wzhudev 选中某列的单元格,然后右键当前列,表现:列不是选中状态,如果点菜单的复制,复制的内容是单元格的
2024_1_10 11_52_54 video.webm

@wzhudev
Copy link
Member Author

wzhudev commented Jan 10, 2024

@wzhudev 选中某列的单元格,然后右键当前列,表现:列不是选中状态,如果点菜单的复制,复制的内容是单元格的 2024_1_10 11_52_54 video.webm

OK. I will fix that in this PR.

@wzhudev
Copy link
Member Author

wzhudev commented Jan 10, 2024

All problems mentioned should be fix now.

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Jan 10, 2024
@wzhudev wzhudev merged commit a24136a into dev Jan 10, 2024
9 checks passed
@wzhudev wzhudev deleted the wzhudev/fix-headermenu-range branch January 10, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 右键菜单取消隐藏列失败 [Bug] 点击列的向下箭头,预期选中当前列
2 participants