Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): update for change #1044

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

DR-Univer
Copy link
Collaborator

@DR-Univer DR-Univer commented Jan 7, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #1037

@DR-Univer DR-Univer added the qa:untested This PR is ready to be tested label Jan 7, 2024
Copy link

github-actions bot commented Jan 7, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (a2141e5) 27.72% compared to head (b6434a4) 27.72%.
Report is 1 commits behind head on dev.

Files Patch % Lines
...src/services/selection/selection-render.service.ts 0.00% 10 Missing and 2 partials ⚠️
.../sheets-ui/src/controllers/selection.controller.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1044      +/-   ##
==========================================
- Coverage   27.72%   27.72%   -0.01%     
==========================================
  Files         740      740              
  Lines       43787    43797      +10     
  Branches     9031     9032       +1     
==========================================
  Hits        12142    12142              
- Misses      27659    27668       +9     
- Partials     3986     3987       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaolixin7 zhaolixin7 added bug Something isn't working qa:rejected and removed qa:untested This PR is ready to be tested bug Something isn't working labels Jan 8, 2024
@zhaolixin7
Copy link

zhaolixin7 commented Jan 8, 2024

@DR-Univer 单元格等于选区,拖拽公式单元格无法移动
2024_1_8 15_26_24 commands.json
2024_1_8 15_26_24 video.webm

@DR-Univer
Copy link
Collaborator Author

DR-Univer commented Jan 8, 2024

@DR-Univer 单元格den等于选区,拖拽公式单元格无法移动 2024_1_8 15_26_24 commands.json 2024_1_8 15_26_24 video.webm

这个问题我在另外的pr解决了 #1035 @zhaolixin7

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:rejected labels Jan 8, 2024
@wzhudev wzhudev merged commit 2867016 into dev Jan 8, 2024
10 checks passed
@wzhudev wzhudev deleted the fix-selection-render-refresh-update branch January 8, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 删除单元格所在的行列后,无法移动单元格
4 participants