Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(facade): add more Facade API #1029

Merged
merged 6 commits into from
Jan 8, 2024
Merged

feat(facade): add more Facade API #1029

merged 6 commits into from
Jan 8, 2024

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 6, 2024

  • I am sure that the code is update-to-date with the dev branch.

#1009

close #

Copy link

github-actions bot commented Jan 6, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

* feat(formula): register function

* feat(formula): register function in worker

* feat(formula): register function, send to worker

* feat(formula): register function in uniscript

* feat(formula): use simple description when register function

* fix(facade): conflict

* fix(formula): register description

* fix(formula): register use service

* fix(formula): custom function service name

docs: add how to contribute to facade API

fix: fix type errors

fix: fix unintented change

fix: tsconfig format

chore: move spec file

feat: init find-replace plugin

feat(facade): add more apis

feat(facade): add API of changing number format

feat(facade): add callback API

feat: add set number format apis

feat(facade): change wrap and alignment API
@wzhudev wzhudev changed the title Wzhudev/feat find replace feat(facade): add more Facade API Jan 8, 2024
@wzhudev wzhudev marked this pull request as ready for review January 8, 2024 10:15
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 130 lines in your changes are missing coverage. Please review.

Comparison is base (36fdeed) 27.77% compared to head (32fae3b) 27.68%.
Report is 3 commits behind head on dev.

Files Patch % Lines
packages/facade/src/apis/sheet/utils.ts 0.00% 36 Missing and 4 partials ⚠️
packages/facade/src/apis/sheet/f-range.ts 12.50% 28 Missing ⚠️
packages/facade/src/apis/sheet/f-workbook.ts 13.79% 22 Missing and 3 partials ⚠️
packages/facade/src/apis/facade.ts 20.00% 11 Missing and 1 partial ⚠️
...replace/src/controllers/find-replace.controller.ts 0.00% 7 Missing ⚠️
packages/find-replace/src/plugin.ts 0.00% 6 Missing ⚠️
.../src/commands/operations/find-replace.operation.ts 0.00% 4 Missing ⚠️
packages/sheets/src/commands/utils/get-target.ts 75.00% 3 Missing ⚠️
packages/core/src/sheets/workbook.ts 0.00% 2 Missing ⚠️
.../find-replace/src/controllers/find-replace.menu.ts 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1029      +/-   ##
==========================================
- Coverage   27.77%   27.68%   -0.10%     
==========================================
  Files         740      746       +6     
  Lines       43836    44029     +193     
  Branches     9041     9095      +54     
==========================================
+ Hits        12177    12190      +13     
- Misses      27671    27824     +153     
- Partials     3988     4015      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzhudev wzhudev merged commit 6224b4f into dev Jan 8, 2024
10 checks passed
@wzhudev wzhudev deleted the wzhudev/feat-find-replace branch January 8, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants