Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): moving col or row relative to freeze area may cause wrong freeze size #1010

Merged
merged 15 commits into from
Jan 5, 2024

Conversation

weird94
Copy link
Contributor

@weird94 weird94 commented Jan 5, 2024

  • I am sure that the code is update-to-date with the dev branch.
  1. close [Bug] 冻结行列时拖拽行列,冻结区域行列数变改为数量减少 #1003
  2. debt decouple freeze render and scroller

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 143 lines in your changes are missing coverage. Please review.

Comparison is base (368ed2c) 23.45% compared to head (f3613ca) 30.18%.
Report is 4 commits behind head on dev.

Files Patch % Lines
...ges/sheets-ui/src/controllers/freeze.controller.ts 0.00% 107 Missing and 22 partials ⚠️
...rc/controllers/editor/formula-editor.controller.ts 0.00% 6 Missing and 1 partial ⚠️
.../services/editor/formula-editor-manager.service.ts 0.00% 4 Missing ⚠️
...ges/sheets-ui/src/views/formula-bar/FormulaBar.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1010      +/-   ##
==========================================
+ Coverage   23.45%   30.18%   +6.73%     
==========================================
  Files         587      527      -60     
  Lines       37505    33647    -3858     
  Branches     7694     6938     -756     
==========================================
+ Hits         8795    10156    +1361     
+ Misses      25152    20097    -5055     
+ Partials     3558     3394     -164     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 5, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

@weird94 weird94 changed the title fix(sheet): move col or row relative to freeze area may cause wrong freeze size fix(sheet): moving col or row relative to freeze area may cause wrong freeze size Jan 5, 2024
@weird94 weird94 added the qa:untested This PR is ready to be tested label Jan 5, 2024
@DR-Univer
Copy link
Collaborator

new bee

@zhaolixin7
Copy link

在冻结区域删除和插入预期是减少和增加

@weird94
Copy link
Contributor Author

weird94 commented Jan 5, 2024

在冻结区域删除和插入预期是减少和增加

fixed

@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Jan 5, 2024
@wzhudev wzhudev merged commit e562723 into dev Jan 5, 2024
9 checks passed
@wzhudev wzhudev deleted the fix/move-col-row-freeze-size branch January 5, 2024 11:57
@wzhudev
Copy link
Member

wzhudev commented Jan 5, 2024

牛逼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 冻结行列时拖拽行列,冻结区域行列数变改为数量减少
4 participants