Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sheet): some bugs on copy&paste #1006

Merged
merged 17 commits into from
Jan 8, 2024
Merged

fix(sheet): some bugs on copy&paste #1006

merged 17 commits into from
Jan 8, 2024

Conversation

yuhongz
Copy link
Contributor

@yuhongz yuhongz commented Jan 4, 2024

  • I am sure that the code is update-to-date with the dev branch.

close #986
close #976
close #616
close #776
close #992

2024.1.5 update

close #990
close #987
close #974

Copy link

github-actions bot commented Jan 4, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 116 lines in your changes are missing coverage. Please review.

Comparison is base (a2141e5) 27.72% compared to head (feb1b7c) 27.77%.
Report is 1 commits behind head on dev.

Files Patch % Lines
.../sheets-ui/src/controllers/auto-fill.controller.ts 18.18% 32 Missing and 4 partials ⚠️
...kages/sheets-ui/src/controllers/clipboard/utils.ts 0.00% 32 Missing ⚠️
...sheets-ui/src/controllers/status-bar.controller.ts 0.00% 14 Missing and 1 partial ⚠️
...kages/sheets-ui/src/services/status-bar.service.ts 0.00% 3 Missing and 12 partials ⚠️
...ts-ui/src/controllers/mark-selection.controller.ts 0.00% 4 Missing and 1 partial ⚠️
...-ui/src/views/status-bar/CopyableStatisticItem.tsx 16.66% 4 Missing and 1 partial ⚠️
.../services/mark-selection/mark-selection.service.ts 0.00% 3 Missing ⚠️
...kages/sheets-ui/src/views/status-bar/StatusBar.tsx 0.00% 2 Missing and 1 partial ⚠️
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 0 Missing and 1 partial ⚠️
.../services/format-painter/format-painter.service.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1006      +/-   ##
==========================================
+ Coverage   27.72%   27.77%   +0.04%     
==========================================
  Files         740      740              
  Lines       43787    43831      +44     
  Branches     9031     9040       +9     
==========================================
+ Hits        12142    12172      +30     
- Misses      27659    27671      +12     
- Partials     3986     3988       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuhongz yuhongz requested a review from jikkai as a code owner January 4, 2024 15:55
@yuhongz yuhongz added the qa:untested This PR is ready to be tested label Jan 5, 2024
@yuhongz yuhongz requested a review from Dushusir as a code owner January 5, 2024 09:09
@zhaolixin7
Copy link

zhaolixin7 commented Jan 6, 2024

@yuhongz #616 使用格式刷白屏
2024_1_6 11_02_39 commands.json
2024_1_6 11_02_39 video.webm
#992 仅填充格式单元格的内容没了
2024_1_5 17_55_27 video.webm

@zhaolixin7 zhaolixin7 added qa:rejected and removed qa:untested This PR is ready to be tested labels Jan 6, 2024
@yuhongz
Copy link
Contributor Author

yuhongz commented Jan 6, 2024

@yuhongz #616 使用格式刷白屏 2024_1_6 11_02_39 commands.json 2024_1_6 11_02_39 video.webm #992 仅填充格式单元格的内容没了 2024_1_5 17_55_27 video.webm

fixed

@wzhudev wzhudev added qa:untested This PR is ready to be tested and removed qa:rejected labels Jan 8, 2024
@zhaolixin7 zhaolixin7 added qa:verified This PR has already by verified by a QA and is considered good enough to be merge and removed qa:untested This PR is ready to be tested labels Jan 8, 2024
@yuhongz yuhongz merged commit 36fdeed into dev Jan 8, 2024
9 checks passed
@yuhongz yuhongz deleted the yuhongz/bugfixs-8 branch January 8, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified This PR has already by verified by a QA and is considered good enough to be merge
Projects
None yet
5 participants