Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Supplement Math Formulas for Formula Engine #2425

Closed
2 of 14 tasks
Dushusir opened this issue Jun 5, 2024 · 1 comment
Closed
2 of 14 tasks

[Feature] Supplement Math Formulas for Formula Engine #2425

Dushusir opened this issue Jun 5, 2024 · 1 comment
Labels
feature request New feature or request scope:formula

Comments

@Dushusir
Copy link
Member

Dushusir commented Jun 5, 2024 •
edited

Initial checklist

  • Is this really a problem?
  • I have searched the Github Issues for similar issues, but did not find anything.

How to contribute formulas: https://univer.ai/guides/sheet/customization/formula#how-to-add-formulas-in-formula-engine

It is highly recommended that you refer to the algorithms of similar formulas that have been implemented

https://github.com/dream-num/univer/blob/dev/packages/engine-formula/src/functions/math/function-map.ts

Especially for

ASIN
ASINH
ATAN
ATAN2
ATANH
COS

These, like Acos, already have corresponding underlying implementations in ArrayValueObject

Solution

Formulas List:

  • ACOTH
  • ASIN
  • ASINH
  • ATAN
  • ATAN2
  • ATANH
  • COS
  • COSH
  • COT
  • COTH
  • CSC
  • CSCH
@Dushusir Dushusir added the feature request New feature or request label Jun 5, 2024
@abdelrahman830a
Copy link

abdelrahman830a commented Jun 7, 2024 •
edited

@abdelrahman830a : I can solve it

This was referenced Jun 11, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@hexf00 hexf00 assigned abdelrahman830a and unassigned DR-Univer Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request scope:formula
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: error handling and array expansion abdelrahman830a/univer
4 participants
@hexf00 @Dushusir @DR-Univer @abdelrahman830a