Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] TRUE FALSE stored as number 0 1 #1534

Closed
2 tasks done
Dushusir opened this issue Mar 9, 2024 · 0 comments · Fixed by #1605
Closed
2 tasks done

[Feature] TRUE FALSE stored as number 0 1 #1534

Dushusir opened this issue Mar 9, 2024 · 0 comments · Fixed by #1605
Assignees
@wzhudev @Dushusir @DR-Univer
Labels
feature request New feature or request scope:sheets basics

Comments

@Dushusir
Copy link
Member

Dushusir commented Mar 9, 2024

Initial checklist

  • Is this really a problem?
  • I have searched the Github Issues for similar issues, but did not find anything.

Problem

TRUE FALSE stored as string

{
  "v": "FALSE", // FALSE
}

Solution

TRUE FALSE stored as boolean number,like

{
  "v": 0, // FALSE
  "t": CellValueType.BOOLEAN
}

Be consistent with Excel
@Dushusir Dushusir added the feature request New feature or request label Mar 9, 2024
@Dushusir Dushusir self-assigned this Mar 9, 2024
wzhudev added a commit that referenced this issue Mar 16, 2024
@wzhudev
fix(sheets): boolean should store as number
49fdb85 
close #1534

BREAKING CHANGE:
Before:
Boolean values ("TRUE" "FALSE") were stored in the IWorkbooData
as strings.
After:
Boolean values would be store as number (0, 1).
@wzhudev wzhudev mentioned this issue Mar 16, 2024
Merged
1 task
wzhudev added a commit that referenced this issue Mar 16, 2024
@wzhudev
fix(sheets): boolean should store as number
aa83aeb 
close #1534

BREAKING CHANGE:
Before:
Boolean values ("TRUE" "FALSE") were stored in the IWorkbooData
as strings.
After:
Boolean values would be store as number (0, 1).
wzhudev added a commit that referenced this issue Mar 16, 2024
@wzhudev
fix(sheets): boolean should store as number (#1605)
78e5426 
* fix(sheets): boolean should store as number

close #1534

BREAKING CHANGE:
Before:
Boolean values ("TRUE" "FALSE") were stored in the IWorkbooData
as strings.
After:
Boolean values would be store as number (0, 1).
ybzky pushed a commit that referenced this issue Mar 19, 2024
@wzhudev
fix(sheets): boolean should store as number (#1605)
84e6cb7 
* fix(sheets): boolean should store as number

close #1534

BREAKING CHANGE:
Before:
Boolean values ("TRUE" "FALSE") were stored in the IWorkbooData
as strings.
After:
Boolean values would be store as number (0, 1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wzhudev wzhudev

@Dushusir Dushusir

@DR-Univer DR-Univer

Labels
feature request New feature or request scope:sheets basics
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sheets): boolean should store as number dream-num/univer
3 participants
@wzhudev @Dushusir @DR-Univer