Skip to content

Commit

Permalink
chore: clean code
Browse files Browse the repository at this point in the history
  • Loading branch information
wzhudev committed Jun 20, 2024
1 parent c1dea41 commit cf964ca
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,10 @@
*/

import { Disposable, LifecycleService, LifecycleStages, toDisposable } from '@univerjs/core';
import { IRenderManagerService } from '@univerjs/engine-render';
import type { IWorkbenchOptions } from '@univerjs/ui';
import { BuiltInUIPart, CanvasPopup, FloatDom, ILayoutService, IUIPartsService } from '@univerjs/ui';
import { BuiltInUIPart, CanvasPopup, FloatDom, IUIPartsService } from '@univerjs/ui';
import type { IDisposable } from '@wendellhu/redi';
import { Inject, Injector, Optional } from '@wendellhu/redi';
import { Inject, Injector } from '@wendellhu/redi';
import { connectInjector } from '@wendellhu/redi/react-bindings';
import React from 'react';
import { delay, filter, take } from 'rxjs';
Expand All @@ -31,11 +30,9 @@ const STEADY_TIMEOUT = 3000;

export class UniverUniUIController extends Disposable {
constructor(
@IRenderManagerService private readonly _renderManagerService: IRenderManagerService,
@Inject(Injector) private readonly _injector: Injector,
@Inject(LifecycleService) private readonly _lifecycleService: LifecycleService,
@IUIPartsService private readonly _uiPartsService: IUIPartsService,
@Optional(ILayoutService) private readonly _layoutService?: ILayoutService
@IUIPartsService private readonly _uiPartsService: IUIPartsService
) {
super();
this._initBuiltinComponents();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@ export const SetSelectionsOperation: IOperation<ISetSelectionsOperationParams> =
type: CommandType.OPERATION,
handler: (accessor, params) => {
const selectionManagerService = accessor.get(SelectionManagerService);
if (!params) {
return false;
}
if (!params) return false;

const { selections, type } = params;
selectionManagerService.replace(selections, type);
Expand Down
4 changes: 0 additions & 4 deletions packages/sheets/src/services/selection-manager.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -438,8 +438,4 @@ export class SelectionManagerService implements IDisposable {

this._refresh(param);
}

// private refreshCurrentSelection(): void {
// this._currentSelection$.next(this._currentSelection);
// }
}

0 comments on commit cf964ca

Please sign in to comment.