Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outdated "DNS - hosts file" part replaced with DNS profiles #412

Merged
merged 2 commits into from
Oct 15, 2023

Conversation

beerisgood
Copy link
Contributor

using the hosts file for filtering etc. is not a sensible or safe way and causes more problems than it solves.
also a long list reduces performance and "thanks" to IPv6 the whole management is too cumbersome and not recommended for normal users

using the hosts file for filtering etc. is not a sensible or safe way and causes more problems than it solves.
also a long list reduces performance and "thanks" to IPv6 the whole management is too cumbersome and not recommended for normal users
@drduh
Copy link
Owner

drduh commented Dec 26, 2022

Can you cite some information about DNS profiles, perhaps a little about how it works?

@beerisgood
Copy link
Contributor Author

Can you cite some information about DNS profiles, perhaps a little about how it works?

Here or as PR in your guide ?

@drduh
Copy link
Owner

drduh commented Dec 26, 2022

PR would be best, but if you add it here I can work on it also.

@troian
Copy link

troian commented Feb 7, 2023

those are DNS servers with some benefits.
also list is missing Pi-Hole

tho I agree editing /etc/hosts is a bad idea - there is still some use for it.

@beerisgood
Copy link
Contributor Author

those are DNS servers with some benefits. also list is missing Pi-Hole

PiHole isn’t recommend for many reasons and doesn’t work by default with devices outside your home.

tho I agree editing /etc/hosts is a bad idea - there is still some use for it.

I can’t even see one useful thing for normal user.

@troian
Copy link

troian commented Feb 7, 2023

PiHole isn’t recommend for many reasons and doesn’t work by default with devices outside your home.
I'm not sure what is meant to be said in this. A phone that is not in the home Wifi network when you are away?

I don't think Pi-Hole has been designed to deal with it.

I can’t even see one useful thing for normal user.

This guide is not for a normal user, for sure 😉

@drduh
Copy link
Owner

drduh commented Mar 19, 2023

I would recommend keeping the hosts method unless that stops working or causes a demonstrable issue.

@beerisgood
Copy link
Contributor Author

Should I rebuild the PR than so both profiles and hosts file is included?

@drduh
Copy link
Owner

drduh commented Aug 13, 2023

Should I rebuild the PR than so both profiles and hosts file is included?

Yes, keep the original hosts stuff for now.

@beerisgood
Copy link
Contributor Author

Should I rebuild the PR than so both profiles and hosts file is included?

Yes, keep the original hosts stuff for now.

Done.

@drduh drduh merged commit 1450e3a into drduh:master Oct 15, 2023
@beerisgood beerisgood deleted the patch-1 branch October 16, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants