Skip to content

Commit

Permalink
make_release: do not annotate boolean switches in public API (nushell…
Browse files Browse the repository at this point in the history
…#635)

related to
- nushell/nushell#10456
- nushell/nushell.github.io#1071

## description
after the changes on boolean switches from
nushell/nushell#10456, we need to not annotate
then with `: bool` when part of a public API.

this PR is required for
nushell/nushell.github.io#1071 to move forward.
  • Loading branch information
amtoine authored Oct 14, 2023
1 parent 907612c commit bc89655
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion make_release/bump-version.nu
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use std log

# bump the minor or patch version of the Nushell project
def main [
--patch: bool # update the minor version instead of the minor
--patch # update the minor version instead of the minor
]: nothing -> nothing {
let version = open Cargo.toml
| get package.version
Expand Down
2 changes: 1 addition & 1 deletion make_release/nu_release.nu
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ use std log

def publish [
crate: path # the path to the crate to publish.
--no-verify: bool # don’t verify the contents by building them. Can be useful for crates with a `build.rs`.
--no-verify # don’t verify the contents by building them. Can be useful for crates with a `build.rs`.
] {
cd $crate

Expand Down
4 changes: 2 additions & 2 deletions make_release/release-note/list-merged-prs
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ def main [
repo: string # the name of the repo, e.g. `nushell/nushell`
date?: datetime # the date of the last release (default to 4 weeks ago, excluded)
--label: string # the label to filter the PRs by, e.g. `good-first-issue`
--pretty: bool # pretty-print for the MarkDown release not
--no-author: bool # do not group the contributions by author
--pretty # pretty-print for the MarkDown release not
--no-author # do not group the contributions by author
] {
let date = $date | default ((date now) - 4wk) | format date "%Y-%m-%d"

Expand Down

0 comments on commit bc89655

Please sign in to comment.