Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Comment for Storage in piece.rs is wrong #724

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

Zyyeric
Copy link
Contributor

@Zyyeric Zyyeric commented Sep 9, 2024

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Signed-off-by: Zyyeric <[email protected]>
Signed-off-by: Zyyeric <[email protected]>
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.48%. Comparing base (1bc3a09) to head (7b49613).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #724   +/-   ##
=======================================
  Coverage   23.48%   23.48%           
=======================================
  Files          55       55           
  Lines        7324     7324           
=======================================
  Hits         1720     1720           
  Misses       5604     5604           
Files with missing lines Coverage Δ
dragonfly-client/src/resource/piece.rs 0.00% <ø> (ø)

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 60d11a0 into dragonflyoss:main Sep 10, 2024
6 checks passed
@Zyyeric Zyyeric deleted the fix_typo branch September 10, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants