Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build broken after jdom upgrade #65

Closed
devkhan opened this issue Jun 28, 2024 · 0 comments · Fixed by #66
Closed

Build broken after jdom upgrade #65

devkhan opened this issue Jun 28, 2024 · 0 comments · Fixed by #66
Assignees
@devkhan
Labels
bug

Comments

@devkhan
Copy link
Collaborator

devkhan commented Jun 28, 2024

jdom was upgraded to jdom2 in this commit.

edu.ucsd.sbrg.escher.util.Validator expects a org.jdom.JDOMException, but it's moved to org.jdom2.JDOMException. org.sbgn raises this exception, so we can't simply replace the import. Because of this, the build fails.

We will have to upgrade/modify the SBGN lib, or find another way.
@devkhan devkhan added the bug label Jun 28, 2024
@devkhan devkhan self-assigned this Jun 28, 2024
@devkhan devkhan changed the title Fix build after jdom upgrade Build broken after jdom upgrade Jun 28, 2024
devkhan added a commit that referenced this issue Jul 8, 2024
@devkhan
[fix] revert jdom upgrade
51cb076 
sbgn depends on an old version of jdom, so we need to revert the upgrade

fixes #65
@devkhan devkhan mentioned this issue Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devkhan devkhan

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] revert jdom upgrade draeger-lab/EscherConverter
1 participant
@devkhan