Silly change #13
Closed
Silly change #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the src_ext/archives cache in all jobs which build opam. The archives-cache stage is converted to a general analysis phase, determining cache keys to use throughout the workflow from a single checkout at the start.
Zarith contains an unecessary dependency on ocamldoc in its configure script - instead of installing ocamlbuild, a fake error-triggering script is installed in ocamldoc's place.
Passing the version explicitly to the creation script is clearer, and also eliminates a duplicate (in several cases, the default for OCAML_VERSION could be out-of-sync with a strategy matrix, breaking caching).
Don't use OS in matrices - stops macOS from holding up the feedback obtained from testing.
Since the latter displays an error message
It takes so long, it's better to do it alongside the main job for parallelism. Merging into the build matrix would improve this further.
The GitHub Actions runners use a Windows short path name for %TEMP% which fouls up the reftests - normalising with Unix.realpath will fix the problem, at least for OCaml 4.13+
Temporary commit - this should be handled by msvs-detect
Temporary solution, as Visual Studio 2022 isn't detected by msvs-detect at the moment.
1ddbec1
to
ead2d38
Compare
The idea here is that a PR which breaks opam fails at build rather than failing at the caching stage.
ead2d38
to
a28889a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.