[WIP] Improve support for having spaces in usernames #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anil Madhavapeddy <[email protected]>
Removes the symbolic link patch, which has been upstreamed from 4.02.3 -> 4.03.0 Signed-off-by: Anil Madhavapeddy <[email protected]>
Signed-off-by: Anil Madhavapeddy <[email protected]>
This helps with the rebase to the latest OPAM alpha4, since that version removes the need for camlp4 with the dose3 upgrade. Signed-off-by: Anil Madhavapeddy <[email protected]>
dra27
reviewed
Sep 22, 2016
| @@ -29,7 +29,7 @@ src/%: | |||
|
|
|||
| # Disable this rule if the only build targets are cold, download-ext or configure | |||
| # to suppress error messages trying to build Makefile.config | |||
| ifneq ($(or $(filter-out cold compiler download-ext lib-pkg configure,$(MAKECMDGOALS)),$(filter own-goal,own-$(MAKECMDGOALS)goal)),) | |||
| ifneq ($(or $(filter-out cold compiler download-ext download-pkg lib-pkg configure,$(MAKECMDGOALS)),$(filter own-goal,own-$(MAKECMDGOALS)goal)),) | |||
dra27
reviewed
Sep 22, 2016
| @@ -10,7 +10,7 @@ CAN_PKG=0 | |||
| endif | |||
|
|
|||
| ifndef FETCH | |||
| ifneq ($(shell command -v curl > /dev/null),) | |||
| ifneq ($(shell command -v curl 2> /dev/null),) | |||
|
Fairly obsolete now :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generally improves shell quoting behaviour so that "Anil Madhavapeddy" is an acceptable Windows username (and incidentally, the default that it offered me in a fresh installation upon grokking my name).
However, it breaks at camlp4 installation time. This was a good place to stop since the rebasing of this branch over the opam#master branch eliminates the need for Camlp4 due to a patched version of Dose3 being present, so we can hopefully avoid patching anything to do with camlp4 on Windows...
However, this entire effort may be pointless since a large, large chunk of opam repository is likely to be broken on usernames with spaces due to shell quoting issues. It should improve the quality of the core build, at least...
Joint work with @dra27