Fix error from ocaml#5356

Logical statement became accidentally inverted.
dra27 · Feb 14, 2024 · 07f0abf · 07f0abf
1 parent 7177e4c
commit 07f0abf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/master_changes.md b/master_changes.md
@@ -60,6 +60,7 @@ users)
 ## Env
   * Fix shell detection on Windows when opam is called via Cygwin's /usr/bin/env even though cmd/powershell is used [#5797 @kit-ty-kate]
   * Fix incorrect deduplication of environment variables on update. Effect was that FOO += "" would occlude the value of FOO in the environment [#5837 @dra27]
+  * Fix regression from #5356 on the detection of out-of-date environment variables. As part of a refactoring, a filter predicate got inverted [#5837 @dra27]
 
 ## Opamfile
 

diff --git a/src/state/opamEnv.ml b/src/state/opamEnv.ml
@@ -625,7 +625,7 @@ let is_up_to_date_raw ?(skip=OpamStateConfig.(!r.no_env_notice)) updates =
           if reverse_env_update ~sepfmt var op arg
               (split_var ~sepfmt var v) = None then upd::notutd
           else List.filter (fun upd ->
-              OpamStd.Env.Name.equal_string var upd.envu_var) notutd)
+              not (OpamStd.Env.Name.equal_string var upd.envu_var)) notutd)
       []
       updates
   in