Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -I include parameter to samba.sh #143

Merged
merged 1 commit into from
Sep 23, 2018

Conversation

strayer
Copy link
Contributor

@strayer strayer commented Jun 21, 2018

This PR adds a new parameter -I to samba.sh. The user can use this to add additional configuration to smb.conf, in my example a TimeMachine share with not yet supported config options.

Example:

# docker-compose.yml
version: '3.4'

services:
  samba:
    volumes:
      - /mnt/shared:/mnt/shared
      - /mnt/timemachine:/mnt/timemachine
      - ./timemachine.conf:/etc/samba/timemachine.conf:ro
    ports:
      - 445:445
    command: >
      -w WORKGROUP
      -g "fruit:model = RackMac"
      -g "fruit:advertise_fullsync = true"
      -g "fruit:aapl = true"
      -s "shared;/mnt/shared/;yes;no;no;user"
      -I "/etc/samba/timemachine.conf"
; timemachine.conf
[TimeMachine]
    path = /mnt/timemachine
    browsable = no
    vfs objects = catia fruit streams_xattr
    guest ok = no
    fruit:aapl = yes
    valid users = user
    read only = no

@albertmichaelj
Copy link

I'll second this pull request. This is exactly the option that I was looking for to make this a perfect samba setup. Please do merge this. Thanks for your work on this excellent samba docker container!

@dperson dperson merged commit 2b1b0c2 into dperson:master Sep 23, 2018
@dperson
Copy link
Owner

dperson commented Sep 23, 2018

This look great thanks.

@dperson dperson self-assigned this Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants