/usr/bin/samba.sh: line 140: $2: unbound variable

[millermarkj]

I use v2tec/watchtower to keep my containers updated. samba updated last night and now won't run. Starting it manually reports:

mark@system:/opt/svc/samba$ docker-compose up
Recreating samba_samba_1 ... done
Attaching to samba_samba_1
samba_1  | /usr/bin/samba.sh: line 140: $2: unbound variable
samba_samba_1 exited with code 1

Based on a prior issue I double-checked the syntax. But nothing seems to make it start. My docker-compose file:

version: "3"
services:
  samba:
    image: "dperson/samba"
    restart: always
    ports:
      - 139:139
      - 137-138:137-138/udp
      - 445:445
    volumes:
      - "/volume1:/volume1:ro"
      - "/volume2:/volume2"
      - "/etc/localtime:/etc/localtime:ro"
    networks:
      - backend
    environment:
      - USERID="1005"
      - GROUPID="30"
      - TZ=EST5EDT
    command: '-r -s "volume1;/volume1"
                 -s "volume2;/volume2"'
    labels:
      - com.centurylinklabs.watchtower.enable=true
networks:
  backend:
    external: true

[mxwlsavard]

Likely not related to your issue, but v2tec/watchtower has moved to containrrr/watchtower. The v2tec image hasn't been updated in a year :)

[millermarkj]

Had no idea! I'll switch right away.

[dperson]

@millermarkj line 140 is a function to setup a samba user... which your compose doesn't seem to be doing. Did updating the watchtower resolve the issue?

[millermarkj]

No. I was able to resolve this by building my own container and updating the samba.sh script.

There appears to be environment variable processing involved any env that STARTS with "USER". USERID meets that criteria. It seems you attempted to handle that case and clear the environment earlier, but for some reason that regex match doesn't end up unsetting the environment variable.

Also, the loop that processes any env that starts with USER doesn't seem to handle the empty/missing case of USER= or USER="".

[dperson]

Thanks for the bug report, I think that it should be fixed now.

[millermarkj]

Have you pushed any changes? Git isn't showing any updates and the dperson/samba container pulled has the same hash.

[dperson]

Doh! I've pushed the change now. I've been working on these while sitting in airports for a lot of travel that I've had to do just recently, jet lag doesn't help me remember details alas...