-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors after recent update #214
Comments
Hi, me too... |
The devs said he fat fingered it and fixed already but I can't get any newer image. Sick as a dog at the moment. Trying to settle in to watch stuff off my server. And now this :( can't connect to my server. Very very very very very grumpy at the moment :( Edit: #213 I think the top closed issues are the same as this but no one looks.... |
Think it was just missing a few extra brackets and have submitted a PR in #215. Have built and run on my Pi 4 and it seems to have fixed it, although I don't use any of the new features so not 100% sure if the new functionality is working. |
I reverted to commit ad05a2b and build new docker image, it's now working fine. |
Sorry guys, what I put in worked in my shell here in testing but not in the container. It should be fixed for real now. |
Well those errors went away at least. But now it has some unbound variables
Unless something else changed or I screwed it up trying to force refresh
|
Same error here: |
This was 1 crazy bad update then. It always worries me when stuff like this happens. A simple docker and docker compose test would of caught this I'm sure (not that many configurations and I doubt ours are complicated edge cases) |
Sorry guys, I didn't really want to change how these variables were parsed, but kept getting requests for it. I hope it's really really fixed now. |
No worries. Code breaks. But you might want to set up a testing branch or something.... :p |
We have liftoff!!!
|
In retrospect I really should have. |
Thanks for verifying @WilliamStam ! |
Hehe now maybe I can finish watching that episode of ##redacted## that stopped working half way through cause watchtower updated the image :P Appreciate the work. I was ready to find a voodoo doll with your name on it earlier tho. Then I just gave up and tried sleeping. Couldn't do a thing on the network here since everything is network shared :( |
Hope you feel better soon. |
Worked for me aswel. |
I opened #216 in response to this - versioned tags would have given us an easy downgrade fix option. |
I'm having problems since recent update (i see you updated git 3hrs ago):
/usr/bin/samba.sh: line 245: syntax error near unexpected token
<(env | awk '/^GLOBAL/ {sub (/^[^=]*=/, "", $0); print}')' ,/usr/bin/samba.sh: line 245:
done <(env | awk '/^GLOBAL/ {sub (/^[^=]*=/, "", $0); print}')'The text was updated successfully, but these errors were encountered: