New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return errors instead of logging/go modules/comments #12

Open

KatamariJr wants to merge 3 commits into dpapathanasiou:master from KatamariJr:master

KatamariJr commented Dec 6, 2019 •

edited

Loading

Added go.mod file to support modules.
It is more useful to return the errors rather than logging them, whatever code calls this library would be the one that should actually handle logging, and it makes more sense to wrap that error that gets returned instead.
Cleaned up the comments, as they seemed to be outdated/not written as well as they could be.

Also, if you merge this, you should tag it as v1.0.0

Austin Green added 3 commits

December 6, 2019 17:05


add go mod

c16dc2b


return errors instead of logging

4e1db22

-cleaned up comments to make more sense


use %w verb

b10c3c6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment