-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Type Hints to TTR module #18
Comments
@dpalmasan Can I work on this issue? |
@sourvad sure! Feel free to work on this issue |
Hello @dpalmasan ,there is no docstring for the following parameters:
Should type hints be added for these parameters as well, or is it abstracted away by design? |
Good catch! @sourvad Probably we need to also update the docstrings |
Gotcha, will do. |
@dpalmasan I believe it's done. Build passed and ran pre-commit. |
Add type hints to `TTR` module (#18 )
PR merged, closing. |
TTR module can be found here:
https://github.com/dpalmasan/TRUNAJOD2.0/blob/master/src/TRUNAJOD/ttr.py
For example, using type hints we could define:
as
The text was updated successfully, but these errors were encountered: