fix incorrect "Username or password is incorrect" error #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes incorrect "Username or password is incorrect" error
|
@doy It would be great if this can be merged |
|
works great for me, don't have the issue anymore |
|
Seems that this does not fix the issue on all platforms #182 |
impact-merlinzerbe
pushed a commit
to impact-merlinzerbe/rbw
that referenced
this pull request
Jun 19, 2024
the official bitwarden cli uses the following parameters when logging in (POST /connect/token): ``` scope=api offline_access client_id=cli deviceType=25 deviceIdentifier=xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx deviceName=linux grant_type=password username=xxxxxxxxxxxxxxxxxxxxxxxxx password=xxxxxxxxxxxxxxxxxxxxxxxxx ``` before this commit, rbw uses these parameters: ``` scope=api offline_access client_id=desktop deviceType=8 deviceIdentifier=xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx deviceName=rbw devicePushToken= grant_type=password username=xxxxxxxxxxxxxxxxxxxxxxxxx password=xxxxxxxxxxxxxxxxxxxxxxxxx ``` although there are multiple differences, changing the client id from "desktop" to "cli" is sufficient to fix the issue.
impact-merlinzerbe
pushed a commit
to impact-merlinzerbe/rbw
that referenced
this pull request
Jun 19, 2024
the official bitwarden cli uses the following parameters when logging in (POST /connect/token): ``` scope=api offline_access client_id=cli deviceType=25 deviceIdentifier=xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx deviceName=linux grant_type=password username=xxxxxxxxxxxxxxxxxxxxxxxxx password=xxxxxxxxxxxxxxxxxxxxxxxxx ``` before this commit, rbw uses these parameters: ``` scope=api offline_access client_id=desktop deviceType=8 deviceIdentifier=xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx deviceName=rbw devicePushToken= grant_type=password username=xxxxxxxxxxxxxxxxxxxxxxxxx password=xxxxxxxxxxxxxxxxxxxxxxxxx ``` although there are multiple differences, changing the client id from "desktop" to "cli" is sufficient to fix the issue.
|
i believe this should be fixed in #186 (i think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I hacked together a proxy that basically proxies everything bitwarden related on my machine and prints the various requests and responses. I then logged in to bitwarden via the Firefox extension which works (no surprises there) and looked at the logs from my proxy and started comparing each request with what rbw is doing.
I noticed that the
client_idquery parameter in the/connect/tokenrequest is set todesktopbut the Firefox extension is setting it tobrowser. After changing tobrowserI am now able to login again and I am not getting the "Username or password is incorrect" message.This PR fixes #182