Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding DI.External to runtime with its history #37103

Merged
merged 12 commits into from
Jun 3, 2020
Merged

Adding DI.External to runtime with its history #37103

merged 12 commits into from
Jun 3, 2020

Conversation

maryamariyan
Copy link
Member

No description provided.

pakrym and others added 9 commits December 13, 2018 10:36
@pakrym
Add spec tests for external container implementations (dotnet/extensi…
92e1f66 
…ons#629)

Commit migrated from dotnet/extensions@5b3645a
Merge branch 'release/2.2'
4511b8d 
Commit migrated from dotnet/extensions@604018c
@natemcmaster
Disable transitive project references in test projects (dotnet/extens…
b967648 
…ions#1834)

Commit migrated from dotnet/extensions@e7d5bea
@davidfowl
Added verification test for resolving singleton from scoped container. (
093c19c 
dotnet/extensions#2236)

* Added verification test for resolving singleton from scoped container.

* Skip failing test with the Unity container


Commit migrated from dotnet/extensions@732d143
Support netcoreapp3.1 TFM (dotnet/extensions#2336)
0173e3e 
* Support netcoreapp3.1 TFM

* Unpin SDK for source build

* Update to preview1 branding


Commit migrated from dotnet/extensions@32cc816
Merge branch 'release/3.1'
e32bbc6 
Commit migrated from dotnet/extensions@785e2b0
@sharwell
Normalize all file headers to the expected Apache 2.0 license
5429b1a 
Commit migrated from dotnet/extensions@cec6e75
@sharwell
Switch file headers to the MIT license
038c765 
Commit migrated from dotnet/extensions@321a30c
@maryamariyan
Merge branch 'di-external' of /Users/maryam/CodeHub/Extensions into d…
66d2de9 
…i-external
@maryamariyan maryamariyan self-assigned this May 27, 2020
@tarekgh
Copy link
Member

tarekgh commented May 27, 2020

Thanks @maryamariyan for brining in these tests

@maryamariyan maryamariyan requested a review from safern May 27, 2020 23:29
This was referenced May 28, 2020
Merged
Closed
@maryamariyan
Copy link
Member Author

moved files slightly so that DI tests now contain 3 folders:

  • DI.External.Tests (with its own csproj)
  • DI.Specification.Tests (used in the other two)
  • DI.Tests (with its own csproj)

@maryamariyan maryamariyan mentioned this pull request May 28, 2020
Open
@maryamariyan
Copy link
Member Author

maryamariyan commented May 28, 2020 •
edited
Loading

Failures on net472:

System.IO.FileLoadException : Could not load file or assembly 'Lamar, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. A strongly-named assembly is required. (Exception from HRESULT: 0x80131044)
   at Microsoft.Extensions.DependencyInjection.Specification.LamarDependencyInjectionSpecificationTests.CreateServiceProviderImpl(IServiceCollection serviceCollection)
   at Microsoft.Extensions.DependencyInjection.Specification.DependencyInjectionSpecificationTests.OuterServiceCanHaveOtherServicesInjected() in /_/src/libraries/Microsoft.Extensions.DependencyInjection/tests/DI.Specification.Tests/DependencyInjectionSpecificationTests.cs:line 230

System.IO.FileLoadException : Could not load file or assembly 'DryIoc, Version=3.0.2.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. A strongly-named assembly is required. (Exception from HRESULT: 0x80131044)
   at Microsoft.Extensions.DependencyInjection.Specification.DryIocDependencyInjectionSpecificationTests.CreateServiceProvider(IServiceCollection serviceCollection)
   at Microsoft.Extensions.DependencyInjection.Specification.DependencyInjectionSpecificationTests.ServicesRegisteredWithImplementationTypeCanBeResolved() in /_/src/libraries/Microsoft.Extensions.DependencyInjection/tests/DI.Specification.Tests/DependencyInjectionSpecificationTests.cs:line 24

cc: @safern

@jaredpar jaredpar mentioned this pull request May 28, 2020
Closed
@maryamariyan
Enables DI.External
77c69b9 
Moving around files in DI tests, correcting folder structure
Disable tests failing on mono and for netfx
@maryamariyan
Copy link
Member Author

The CI already went green. I just force pushed my changes now so that my commits-only were squashed together, keeping the commit history intact, doing a merge commit to submit the PR.

@maryamariyan maryamariyan merged commit dfbba33 into dotnet:master Jun 3, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tarekgh tarekgh tarekgh approved these changes

@safern safern safern left review comments

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

Assignees

@maryamariyan maryamariyan

Labels
area-Extensions-DependencyInjection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@maryamariyan @tarekgh @JunTaoLuo @safern @pakrym @natemcmaster @davidfowl @sharwell