Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'Microsoft (R)', 'Microsoft (C)' from version message. #7672

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

tmds
Copy link
Member

@tmds tmds commented Jun 3, 2022

@tmds
Copy link
Member Author

tmds commented Jun 3, 2022

These are the translated strings.

I think these are fine:

MSBuild verze {0} pro {1}
MSBuild, Version {0} für {1}
MSBuild versión {0} para {1}
MSBuild version {0} pour {1}
MSBuild versione {0} per {1}
MSBuild {0} dla platformy {1}
MSBuild versão {0} para {1}

These are probably ok since they start/end with {0}, {1}, and MSBuild:

{1} 向け MSBuild バージョン {0}
{1}용 MSBuild 버전 {0}
MSBuild версии {0} для {1}
{1} için MSBuild sürüm {0}

Unsure:

用于 {1} 的 生成引擎版本 {0}
MSBuild for {1} {0} 版

For the last one, maybe the last char needs to be removed because because the next line was removed from the message.

@rainersigwald
Copy link
Member

For the individual translations, the tooling should have marked them as state needs-review-translation after a build that changed the English string in the .resx. That will cause them to get looked at again by the loc teams and eventually we'll get a PR like #7650 with vetted updated strings.

Did that not happen for you? In any case I pushed a commit that marked them that way.

Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on the content, thanks for doing this :)

@reflectronic
Copy link

This should also close #5024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Microsoft (R) Build Engine' 'Copyright (C) Microsoft Corporation. All rights reserved.'
7 participants