Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the mac/iOS workloads #24263

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Update the mac/iOS workloads #24263

merged 2 commits into from
Aug 21, 2024

Conversation

mattleibow
Copy link
Member

@mattleibow mattleibow commented Aug 15, 2024

Description of Change

We are "multitargeting" to 17.0, but this was only really supported in the latest iOS workloads.

Right now, the 17.0 TFM version will always be 17.2.

Maui 8.0.80 with TFM 17.0 is actually

// Microsoft.iOS, Version=17.2.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065

When I use the latest SDKs and workloads and try multitarget SkiaSharp to 17.0 because I want to support everyone, I get this error:

CSC : error CS1705: Assembly 'Microsoft.Maui' with identity 'Microsoft.Maui, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' uses 'Microsoft.MacCatalyst, Version=17.2.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065' which has a higher version than referenced assembly 'Microsoft.MacCatalyst' with identity 'Microsoft.MacCatalyst, Version=17.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065' [D:\GitHub\SkiaSharp\source\SkiaSharp.Views.Maui\SkiaSharp.Views.Maui.Core\SkiaSharp.Views.Maui.Core.csproj::TargetFramework=net8.0-maccatalyst17.0]

I can't use 17.2 in SkiaSharp with the new SDK as the only TFM versions that are supported are 17.0 and 17.5

On SR 8 #24321

We are "multitargeting" to 17.0, but this was only really supported in the latest iOS workloads.

Right now, the 17.0 TFM version will always be 17.2.
@mattleibow
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

mattleibow added a commit to mono/SkiaSharp that referenced this pull request Aug 15, 2024
@mattleibow
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

mattleibow added a commit to mono/SkiaSharp that referenced this pull request Aug 16, 2024
mattleibow added a commit to mono/SkiaSharp that referenced this pull request Aug 16, 2024
@rmarinho rmarinho requested review from dalexsoto, PureWeen and rmarinho and removed request for StephaneDelcroix August 19, 2024 08:51
@mattleibow
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho merged commit 6a30d35 into main Aug 21, 2024
97 checks passed
@rmarinho rmarinho deleted the dev/ios-bump branch August 21, 2024 09:25
Redth pushed a commit that referenced this pull request Aug 22, 2024
* Update the mac/iOS workloads

We are "multitargeting" to 17.0, but this was only really supported in the latest iOS workloads.

Right now, the 17.0 TFM version will always be 17.2.

* not needed anymore
@samhouts samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Aug 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-net8.0-nightly This may be available in a nightly release! fixed-in-net9.0-nightly This may be available in a nightly release!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants