Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Android FontModel Glide In-Memory Caching #24021

Merged

Conversation

albyrock87
Copy link
Contributor

Description of Change

Thanks to additional logging I've discovered FontModel-related images are not being cached in memory.

https://bumptech.github.io/glide/tut/custom-modelloader.html#implementing-buildloaddata

A Key that will be used as part of our disk cache keys (the model’s equals() and hashCode() methods are used for the in memory cache key).

Without this fix we're filling up the memory cache with identical FontModels.
This brings a very good improvement with applications using FontIconSource.

Issues Fixed

Slightly improves #6625 on FontIconSource by fixing the non-working in-memory cache (which has synchronous loading).

@albyrock87 albyrock87 requested a review from a team as a code owner August 5, 2024 17:00
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Aug 5, 2024
Copy link
Contributor

Hey there @albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

I wonder if this helps with this: #22757

@mattleibow
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

PureWeen commented Aug 5, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen merged commit 7cb2341 into dotnet:main Aug 5, 2024
97 checks passed
@albyrock87 albyrock87 deleted the fix-android-glide-fontmodel-caching branch August 6, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community ✨ Community Contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants