Fixes Android FontModel Glide In-Memory Caching #24021
Merged
+18
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Thanks to additional logging I've discovered
FontModel
-related images are not being cached in memory.https://bumptech.github.io/glide/tut/custom-modelloader.html#implementing-buildloaddata
Without this fix we're filling up the memory cache with identical
FontModel
s.This brings a very good improvement with applications using
FontIconSource
.Issues Fixed
Slightly improves #6625 on
FontIconSource
by fixing the non-working in-memory cache (which has synchronous loading).