[Android] Custom shell back button color #22940
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
reviewed
Jun 9, 2024
| @@ -392,7 +394,7 @@ protected virtual async void UpdateLeftBarButtonItem(Context context, AToolbar t | |||
| DrawerArrowDrawable icon = null; | |||
| bool defaultDrawerArrowDrawable = false; | |||
|
|
|||
| var tintColor = Colors.White; | |||
| var tintColor = Shell.GetForegroundColor(page) ?? Colors.White; | |||
There was a problem hiding this comment.
Does this make it match the behavior on iOS and Android?
There was a problem hiding this comment.
Yes, here's an iOS sample:
There was a problem hiding this comment.
Is the icon misaligned on iOS?
There was a problem hiding this comment.
I used the default icon that has been included in the test app. It is too big, so it is why it looks like this. It's a different bug but not related to this change
jsuarezruiz
added
platform/android 🤖
area-controls-shell
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Jun 11, 2024
There was a problem hiding this comment.
Is the icon misaligned on iOS?
|
Would this fix an SVG that has multiple colors as well? like if you wanted a company logo with multiple colors because at the moment those are all white as well. |
PureWeen
requested changes
Jul 18, 2024
Redth
approved these changes
Jul 18, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Commenter does not have sufficient privileges for PR 22940 in repo dotnet/maui |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #22450