Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Fix Issue22433Test #22753

Merged
merged 3 commits into from
Jun 1, 2024
Merged

[Housekeeping] Fix Issue22433Test #22753

merged 3 commits into from
Jun 1, 2024

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix Issue22433Test. Rebasing some PRs I realized that the Windows UI test step fails due to a test with a snapshot with slight differences.
Issue22433_Default-diff
This PR just apply changes to the Issue22433 reference snapshot.

@jsuarezruiz jsuarezruiz requested a review from a team as a code owner May 31, 2024 11:16
mattleibow
mattleibow previously approved these changes May 31, 2024
@mattleibow
Copy link
Member

I see there are a few others for this issue.

@Foda are these changes expected with all your WinUI changes? I just want to make sure that these tiny differences are expected and not some side effect of some horrible bug.

@Foda
Copy link
Member

Foda commented May 31, 2024

I see there are a few others for this issue.

@Foda are these changes expected with all your WinUI changes? I just want to make sure that these tiny differences are expected and not some side effect of some horrible bug.

Yeah, it looks like this is a slight difference due to animation timing or something.

@mattleibow mattleibow enabled auto-merge (squash) May 31, 2024 18:47
@mattleibow mattleibow merged commit 0f5c4a5 into main Jun 1, 2024
49 checks passed
@mattleibow mattleibow deleted the fix-main-issue22433 branch June 1, 2024 06:28
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants