Fix the FontImageSource for Windows Unpackaged #22646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
force-pushed
the
dev/font-image-source
branch
2 times, most recently
from
17d8b3f
to
daa770b
Compare
mattleibow
commented
May 24, 2024
| <FontImageSource Glyph="A" Color="Black" FontFamily="OpenSansRegular"/> | ||
| <FontImageSource Glyph="" Color="Black" FontFamily="FA"/> |
There was a problem hiding this comment.
Changing this because this test also had an issue with the font because it has a space. However, it was not noticeable since the fonts are close.
Foda
previously approved these changes
May 24, 2024
jfversluis
previously approved these changes
May 27, 2024
MartyIX
reviewed
May 27, 2024
src/Core/src/ImageSources/FontImageSourceService/FontImageSourceService.Windows.cs
Outdated
Show resolved
Hide resolved
MartyIX
reviewed
May 27, 2024
src/Core/src/ImageSources/FontImageSourceService/FontImageSourceService.Windows.cs
Show resolved
Hide resolved
jsuarezruiz
added
platform/windows 🪟
area-fonts
|
/rebase |
github-actions
bot
force-pushed
the
dev/font-image-source
branch
from
7942d6a
to
af99b61
Compare
Foda
previously approved these changes
May 28, 2024
jfversluis
approved these changes
May 30, 2024
41 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR fixes the case where using the
Urifor URI processing results in the fragment being URI encoded. Win2D does not accept encoded URIs, so we need to capture the fragment before processing.Issues Fixed
Fixes #21993