Make sure to redraw the background drawable when the size is updated #22626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
previously approved these changes
May 24, 2024
jsuarezruiz
reviewed
May 27, 2024
There was a problem hiding this comment.
It is not important for this PR, but just like we do in portrait, in landscape we must eliminate the navigation bar.
|
Added Windows snapshots |
jsuarezruiz
approved these changes
May 28, 2024
|
@jsuarezruiz only added some screen shots to finalize the tests I wrote. I'm going to merge this one based on his approval. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Inside the MauiDrawable we store the Android rect and then compare the size to see if we need to redraw it. It looks like the bounds object that's passed into OnBoundsChange is the same object reference as the one we store. So, when those bounds values get updated, our stored bounds still matches because they are the same instance
This broke because of this PR because now we're creating way fewer ping pongs of layout invalidation which will cause issues like this to some time surface.
Issues Fixed
Fixes #22606