IndexOf() stackOverflow fix (#20083)

[kubaflo]

Description of Change

A small correction to this PR: #20083 that fixes the StackOverflow exception

Issues Fixed

Fixes #20083
Fixes #21991

[symbiogenesis]

This won't fix it. There is an infinite recursive loop. Sorry about that! Good catch.

I would replace lines 150-153 with the following and leave everything else unchanged.

if (enumerable is List<T> list)
{
	var listPredicate = new Predicate<T>(predicate);
	return list.FindIndex(listPredicate);
}

if (enumerable is T[] array)
{
	var arrayPredicate = new Predicate<T>(predicate);
	return Array.FindIndex(array, arrayPredicate);
}

[kubaflo]

This won't fix it. There is an infinite recursive loop. Sorry about that! Good catch.

I would replace lines 150-153 with the following and leave everything else unchanged.

if (enumerable is List<T> list)
{
	var listPredicate = new Predicate<T>(predicate);
	return list.FindIndex(listPredicate);
}

if (enumerable is T[] array)
{
	var arrayPredicate = new Predicate<T>(predicate);
	return Array.FindIndex(array, arrayPredicate);
}

The solution that I'm proposing fixes it - I tested it

[symbiogenesis]

This won't fix it. There is an infinite recursive loop. Sorry about that! Good catch.
I would replace lines 150-153 with the following and leave everything else unchanged.

if (enumerable is List<T> list)
{
	var listPredicate = new Predicate<T>(predicate);
	return list.FindIndex(listPredicate);
}

if (enumerable is T[] array)
{
	var arrayPredicate = new Predicate<T>(predicate);
	return Array.FindIndex(array, arrayPredicate);
}

The solution that I'm proposing fixes it - I tested it

I think testing more would show that it still isn't fixed, because the self-referential call. The code I propose should fix it, with no other changes on any lines.

[kubaflo]

This won't fix it. There is an infinite recursive loop. Sorry about that! Good catch.
I would replace lines 150-153 with the following and leave everything else unchanged.

if (enumerable is List<T> list)
{
	var listPredicate = new Predicate<T>(predicate);
	return list.FindIndex(listPredicate);
}

if (enumerable is T[] array)
{
	var arrayPredicate = new Predicate<T>(predicate);
	return Array.FindIndex(array, arrayPredicate);
}

The solution that I'm proposing fixes it - I tested it

I think testing more would show that it still isn't fixed, because the self-referential call. The code I propose should fix it, with no other changes on any lines.

Yep, this works

[rmarinho]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

Could we include some unit tests?

[rmarinho]

Yeah, since it passed the first time, would be great to add a test to reproduce the issue so it doesn't happen again

[symbiogenesis]

Added unit tests here:

#21978

[kubaflo]

@rmarinho so can we please merge these 2 PRs since it is annoying that we cannot debug now without making these changes to the source code