Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border visual tests #17633

Closed
wants to merge 9 commits into from
Closed

Conversation

BretJohnson
Copy link
Member

@BretJohnson BretJohnson commented Sep 25, 2023

Description of Change

Fully enable the border tests, started as part of #17310.
We decided to break the tests out of 17310, into this PR, so we can merge 17310 ASAP and merge the test PR (this one) shortly after.

So the sequence should be:

  • Finalize [Windows] Fixes border content clipping #17310 and merge it (hopefully very shortly today).
  • Rebase this PR on latest main.
  • Finalize and merge this PR, adding the UI tests (hopefully later today - it's close, but we don't want to block on it).

jstedfast
jstedfast previously approved these changes Sep 25, 2023
jstedfast
jstedfast previously approved these changes Sep 25, 2023
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
System.TimeoutException : Timed out waiting for element...
Launching the test processes on CI again to see if can pass the added ones.

@samhouts samhouts added the s/pr-needs-author-input PR needs an update from the author label Oct 5, 2023
@ghost
Copy link

ghost commented Oct 5, 2023

Hi @BretJohnson. We have added the "s/pr-needs-author-input" label to this issue, which indicates that we have an open question/action for you before we can take further action. This PRwill be closed automatically in 14 days if we do not hear back from you by then - please feel free to re-open it if you come back to this PR after that time.

@jstedfast jstedfast self-requested a review October 5, 2023 16:12
@ghost
Copy link

ghost commented Oct 15, 2023

Hi @BretJohnson.
It seems you haven't touched this PR for the last two weeks. To avoid accumulating old PRs, we're marking it as stale. As a result, it will be closed if no further activity occurs within 4 days of this comment. You can learn more about our Issue Management Policies here.

@ghost ghost added the stale Indicates a stale issue/pr and will be closed soon label Oct 15, 2023
@BretJohnson BretJohnson removed the stale Indicates a stale issue/pr and will be closed soon label Oct 16, 2023
@ghost
Copy link

ghost commented Oct 26, 2023

Hi @BretJohnson.
It seems you haven't touched this PR for the last two weeks. To avoid accumulating old PRs, we're marking it as stale. As a result, it will be closed if no further activity occurs within 4 days of this comment. You can learn more about our Issue Management Policies here.

@ghost ghost added the stale Indicates a stale issue/pr and will be closed soon label Oct 26, 2023
@ghost ghost closed this Oct 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
s/pr-needs-author-input PR needs an update from the author stale Indicates a stale issue/pr and will be closed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants