-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Housekeeping] Alternative to #11795 #12134
Conversation
@PureWeen Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PureWeen Thoughts?
Would it be possible to add tests? I have some modal tests here.
https://github.com/dotnet/maui/tree/main/src/Controls/tests/DeviceTests/Elements/Modal
I'm thinking you can push the page then grab the VC to see the presentation style?
src/Controls/tests/DeviceTests/Elements/Modal/ModalTests.iOS.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
Description of Change
Allow transparent modal pages. Alternative to #11795
Issues Fixed
Fixes #12031