Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting thread as background #3274

Merged
merged 1 commit into from
May 29, 2020
Merged

Setting thread as background #3274

merged 1 commit into from
May 29, 2020

Conversation

eddynaka
Copy link

Summary of the changes (Less than 80 chars)

  • Setting thread as background to solve a problem in UseWindowsService

#2836

@eddynaka eddynaka requested a review from Tratcher as a code owner May 29, 2020 15:09
@Tratcher Tratcher self-assigned this May 29, 2020
@Tratcher
Copy link
Member

Were you able to reproduce #2836 and verify this fixes it?

@eddynaka
Copy link
Author

Hi @Tratcher ,

with that sample code what were my results:

  • without the change:
    image

  • with the new change:
    image

@Tratcher Tratcher added this to the 5.0.0-preview6 milestone May 29, 2020
@Tratcher Tratcher merged commit 81a947c into dotnet:master May 29, 2020
@Tratcher
Copy link
Member

Thanks

@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tratcher Tratcher Tratcher approved these changes

Assignees

@Tratcher Tratcher

Labels
None yet
Projects
None yet
Milestone
5.0.0-preview6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eddynaka @Tratcher