Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SDL validation to ringed release #3229

Merged
merged 4 commits into from
May 7, 2020
Merged

Move SDL validation to ringed release #3229

merged 4 commits into from
May 7, 2020

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented May 6, 2020

Manual port of #3201

@wtgodbe wtgodbe requested review from jcagme and a team May 6, 2020 18:14
@wtgodbe wtgodbe mentioned this pull request May 6, 2020
Closed
10 tasks
jcagme
jcagme approved these changes May 6, 2020
View reviewed changes
Copy link

@jcagme jcagme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wtgodbe wtgodbe merged commit 29bd9ff into master May 7, 2020
@wtgodbe wtgodbe deleted the wtgodbe/SDLMaster branch May 7, 2020 19:08
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dougbu dougbu dougbu approved these changes

@jcagme jcagme jcagme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wtgodbe @dougbu @jcagme @Pilchie