Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DiagnosticAdapter #3165

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Remove DiagnosticAdapter #3165

merged 1 commit into from
Apr 9, 2020

Conversation

JunTaoLuo
Copy link

According to the migrations documentation, we are actually removing DiagnosticAdapter.

@JunTaoLuo JunTaoLuo requested a review from a team April 9, 2020 05:29
ericstj
ericstj approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪 :shipit:

@JunTaoLuo JunTaoLuo merged commit aba8eb0 into master Apr 9, 2020
@JunTaoLuo JunTaoLuo deleted the johluo/remove-diagnosticadapter branch April 9, 2020 06:19
@rynowak
Copy link
Member

rynowak commented Apr 10, 2020

Amazing. Best DiagnosticSource Adapter change in years 🥂

@sywhang sywhang mentioned this pull request Apr 23, 2020
Closed
@huoyaoyuan huoyaoyuan mentioned this pull request Feb 26, 2021
Open
@wtgodbe
Copy link
Member

wtgodbe commented Aug 18, 2021

@ericstj is there a replacement for DiagnosticsAdapter? We're still using it in aspnetcore, should we just switch to the 5.0.0 version?

dotnet/aspnetcore#35463

@ericstj
Copy link
Member

ericstj commented Aug 18, 2021

You can you use the last stable version from dotnet/extensions. IIRC it was the consensus of @rynowak @anurse @Pilchie that this assembly wasn't providing much value and should be deprecated. Can you just remove usage?

@dougbu dougbu mentioned this pull request Aug 21, 2021
Open
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericstj ericstj ericstj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JunTaoLuo @rynowak @wtgodbe @ericstj