Add code check CI tests, add docs about ReferenceResolution, and other cleanups #1044
Conversation
…the .sln, and other project file cleanups
…nd fix the .sln, and other project file cleanups
…tion, and fix the .sln, and other project file cleanups
eng/scripts/CodeCheck.ps1
Outdated
| if (-not (Test-Path $proj)) { | ||
| LogError "Missing project. Solution references a project which does not exist: $proj. [$sln] " | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggest being more consistent with indentation in the two foreach blocks. (This is a bit harder to read that in needs to be.) The first Foreach-Object block has no indentation but the second has. It's fine if either the close curlies aren't laid out perfectly (as they aren't for the outer line continuation).
FYI I'm going to put dotnet sln $_ list ... into a function in my PowerShell profile 😃
There was a problem hiding this comment.
I too wish the indentation was better. The auto-formatter in VSCode does this, so I'll manually undo it for now.
| <TargetFramework>netstandard1.3</TargetFramework> | ||
| <NoWarn>$(NoWarn);CS1591</NoWarn> | ||
| <BuildOutputTargetFolder>analyzers/dotnet/cs/</BuildOutputTargetFolder> | ||
| <!-- Analyzers cannot be referenced as a ProjectReference. --> |
There was a problem hiding this comment.
You've got a <ProjectReference /> from test/Microsoft.DotNet.Analyzers.Async.Tests.csproj to this project. Did you mean as a Reference?
There was a problem hiding this comment.
This is deliberate. Analyzers, like MSBuild tasks, are "special package" types. Although they carry assemblies, they don't end up in the lib/ folder of a NuGet package. As a result, PackageRef and ProjectRef are not interchangeable, so I've made it an explicit ProjectRef.
There was a problem hiding this comment.
I'll update the comment to clarify.
There was a problem hiding this comment.
I understand the context but saying "PackageReference" here confuses the issue. My thought was just to say "as a Reference".
There was a problem hiding this comment.
I updated the comment. Let me know if the update is clearer.
src/Configuration/Config/test/Microsoft.Extensions.Configuration.Tests.csproj
Outdated
Show resolved
Hide resolved
| @@ -6,6 +6,10 @@ | |||
| <PackageTags>$(PackageTags);analyzers</PackageTags> | |||
| <NoWarn>$(NoWarn);CS1591</NoWarn> | |||
| <BuildOutputTargetFolder>analyzers/dotnet/cs/</BuildOutputTargetFolder> | |||
| <!-- Analyzers cannot be referenced as a ProjectReference. --> | |||
…r cleanups (dotnet/extensions#1044) Changes: * Add a step which checks that generated code is up to date * Copy over the documentation on how to work with `<reference>` * Fixup a broken reference in the .sln * Fix the casing on Microsoft.Extensions.ValueStopwatch.Sources * Remove some unused references and variables\n\nCommit migrated from dotnet/extensions@92acd8b
…r cleanups (dotnet/extensions#1044) Changes: * Add a step which checks that generated code is up to date * Copy over the documentation on how to work with `<reference>` * Fixup a broken reference in the .sln * Fix the casing on Microsoft.Extensions.ValueStopwatch.Sources * Remove some unused references and variables\n\nCommit migrated from dotnet/extensions@92acd8b
…r cleanups (dotnet/extensions#1044) Changes: * Add a step which checks that generated code is up to date * Copy over the documentation on how to work with `<reference>` * Fixup a broken reference in the .sln * Fix the casing on Microsoft.Extensions.ValueStopwatch.Sources * Remove some unused references and variables Commit migrated from dotnet/extensions@92acd8b
…r cleanups (dotnet/extensions#1044) Changes: * Add a step which checks that generated code is up to date * Copy over the documentation on how to work with `<reference>` * Fixup a broken reference in the .sln * Fix the casing on Microsoft.Extensions.ValueStopwatch.Sources * Remove some unused references and variables Commit migrated from dotnet/extensions@92acd8b
…r cleanups (dotnet/extensions#1044) Changes: * Add a step which checks that generated code is up to date * Copy over the documentation on how to work with `<reference>` * Fixup a broken reference in the .sln * Fix the casing on Microsoft.Extensions.ValueStopwatch.Sources * Remove some unused references and variables Commit migrated from dotnet/extensions@92acd8b
…r cleanups (dotnet/extensions#1044) Changes: * Add a step which checks that generated code is up to date * Copy over the documentation on how to work with `<reference>` * Fixup a broken reference in the .sln * Fix the casing on Microsoft.Extensions.ValueStopwatch.Sources * Remove some unused references and variables Commit migrated from dotnet/extensions@92acd8b
Changes:
<reference>