Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove implicit references for non-test projects #1037

Merged
merged 3 commits into from
Jan 31, 2019
Merged

Remove implicit references for non-test projects #1037

merged 3 commits into from
Jan 31, 2019

Conversation

natemcmaster
Copy link

Fix #1036

Workaround for dotnet/arcade#1910 which adds implicit references to Spec.Tests which should not be used.

ryanbrandenburg
ryanbrandenburg approved these changes Jan 31, 2019
View reviewed changes
Copy link

@ryanbrandenburg ryanbrandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do you happen to know where we got that guidance offhand? I'd like to read about it a bit more.

@natemcmaster
Copy link
Author

This guidance is in https://xunit.github.io/docs/nuget-packages. It's also been mentioned a few times in release notes, such as https://xunit.github.io/releases/2.3

As a reminder: If you're extending xUnit.net and want to publish your extension as a NuGet package, you should import xunit.extensibility.core and/or xunit.extensibility.execution, not xunit or xunit.core. If you do this wrong, you might have problems generating your NuGet package via dotnet pack.

I can add these to the project file as comments

@natemcmaster
Copy link
Author

/AzurePipelines run all

1 similar comment
@natemcmaster
Copy link
Author

/AzurePipelines run all

@natemcmaster natemcmaster reopened this Jan 31, 2019
dougbu
dougbu approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of typos

....Specification.Tests/src/Microsoft.Extensions.DependencyInjection.Specification.Tests.csproj Outdated Show resolved Hide resolved
src/TestingUtils/Microsoft.AspNetCore.Testing/src/Microsoft.AspNetCore.Testing.csproj Outdated Show resolved Hide resolved
src/TestingUtils/Microsoft.AspNetCore.Testing/src/Microsoft.AspNetCore.Testing.csproj Show resolved Hide resolved
@natemcmaster
Copy link
Author

Updated. Will merge when CI checks are green.

@natemcmaster
Copy link
Author

Apparently azure-pipelines is having issues today.

@natemcmaster natemcmaster reopened this Jan 31, 2019
@natemcmaster natemcmaster merged commit e504b4e into dotnet:master Jan 31, 2019
@natemcmaster natemcmaster deleted the not-a-test branch January 31, 2019 21:20
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Feb 12, 2020
@natemcmaster
Remove implicit references for non-test projects (dotnet/extensions#1037
3bfec56 
)

\n\nCommit migrated from dotnet/extensions@e504b4e
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Feb 15, 2020
@natemcmaster
Remove implicit references for non-test projects (dotnet/extensions#1037
bbca5f3 
)

\n\nCommit migrated from dotnet/extensions@e504b4e
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Feb 28, 2020
@natemcmaster
Remove implicit references for non-test projects (dotnet/extensions#1037
3df0191 
)

Commit migrated from dotnet/extensions@e504b4e
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 2, 2020
@natemcmaster
Remove implicit references for non-test projects (dotnet/extensions#1037
db85bd6 
)

Commit migrated from dotnet/extensions@e504b4e
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020
@natemcmaster
Remove implicit references for non-test projects (dotnet/extensions#1037
b3ee316 
)

Commit migrated from dotnet/extensions@e504b4e
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020
@natemcmaster
Remove implicit references for non-test projects (dotnet/extensions#1037
cea3a2a 
)

Commit migrated from dotnet/extensions@e504b4e
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 17, 2020
@natemcmaster
Remove implicit references for non-test projects (dotnet/extensions#1037
2adbe11 
)

Commit migrated from dotnet/extensions@e504b4e
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 27, 2020
@natemcmaster
Remove implicit references for non-test projects (dotnet/extensions#1037
22ec86f 
)

Commit migrated from dotnet/extensions@e504b4e
@ghost ghost locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pakrym pakrym pakrym approved these changes

@dougbu dougbu dougbu approved these changes

@ryanbrandenburg ryanbrandenburg ryanbrandenburg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@natemcmaster @pakrym @dougbu @ryanbrandenburg