Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collation scaffolding #23388

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Fix collation scaffolding #23388

merged 1 commit into from
Nov 19, 2020

Conversation

roji
Copy link
Member

@roji roji commented Nov 18, 2020 •
edited

Fixes #23386

@roji roji requested a review from a team November 18, 2020 23:59
@roji
Copy link
Member Author

roji commented Nov 19, 2020

@ajcvickers this is a low-priority bugfix, but is also very low risk - maybe we should consider patching later.

@roji roji mentioned this pull request Nov 19, 2020
Closed
@roji roji linked an issue Nov 19, 2020 that may be closed by this pull request
Collations aren't scaffolded correctly #23386
Closed
@roji roji merged commit 92f9a2f into main Nov 19, 2020
@roji roji deleted the CollationScaffolding branch November 19, 2020 09:13
roji added a commit that referenced this pull request Nov 20, 2020
@roji
Fix collation scaffolding (#23388)
b86ebce 
Fixes #23386

(cherry picked from commit 92f9a2f)
@ajcvickers ajcvickers mentioned this pull request Nov 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bricelam bricelam bricelam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collations aren't scaffolded correctly
2 participants
@roji @bricelam