Code cleanup for Microsoft.Data.Sqlite #22188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
approved these changes
Aug 23, 2020
| @@ -821,8 +825,9 @@ public virtual void BackupDatabase(SqliteConnection destination, string destinat | |||
| SqliteException.ThrowExceptionForRC(rc, _db); | |||
| } | |||
|
|
|||
| _aggregates ??= new Dictionary<(string, int), (int, object, delegate_function_aggregate_step, delegate_function_aggregate_final)>( | |||
| FunctionsKeyComparer.Instance); | |||
| _aggregates ??= | |||
There was a problem hiding this comment.
Where would you have expected this to split the line?
There was a problem hiding this comment.
It’s the dangling = issue we discussed previously.
There was a problem hiding this comment.
Ah, right. I'll check if this is configured differently for ??=.
Saibamen
reviewed
Aug 27, 2020
| @@ -1,7 +1,7 @@ | |||
| // Copyright (c) .NET Foundation. All rights reserved. | |||
| // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | |||
|
|
|||
| using System.Reflection; | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.