Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Remove MARS fixtures #21428

Merged
1 commit merged into from
Jun 27, 2020
Merged

Tests: Remove MARS fixtures #21428

1 commit merged into from
Jun 27, 2020

Conversation

smitpatel
Copy link
Member

Since tests uses retrying execution strategy, MARS is not needed.
The failure I had got which made me add MARS was the race condition which tried to enumerate multiple readers at the same time while buffering.

Since tests uses retrying execution strategy, MARS is not needed.
The failure I had got which made me add MARS was the race condition which tried to enumerate multiple readers at the same time while buffering.
@ghost
Copy link

ghost commented Jun 26, 2020

Hello @smitpatel!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 1 minute. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@smitpatel
Copy link
Member Author

@msftbot Please make sure there are at least one approving review.

@ghost
Copy link

ghost commented Jun 26, 2020

Hello @smitpatel!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it has at least 1 approval

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@smitpatel smitpatel requested a review from a team June 26, 2020 21:44
@AndriySvyryd
Copy link
Member

I thought you will fix the race condition, not change the tests 🤣

@smitpatel
Copy link
Member Author

We did that already, #21301
I wonder who approved it. :trollface:

Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok-ok

@smitpatel
Copy link
Member Author

@Pilchie - bot decided to ignore my PR.

@Pilchie
Copy link
Member

Pilchie commented Jun 27, 2020

@msftbot why haven't you merged yet?

@Pilchie
Copy link
Member

Pilchie commented Jun 27, 2020

@msftbot please merge in 1 minute

@ghost
Copy link

ghost commented Jun 27, 2020

Hello @Pilchie!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it has at least 1 approval
  • I won't merge this pull request until after the UTC date Sat, 27 Jun 2020 03:47:06 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@Pilchie
Copy link
Member

Pilchie commented Jun 27, 2020

@msftbot please merge in 1 minute

@ghost
Copy link

ghost commented Jun 27, 2020

Hello @Pilchie!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it has at least 1 approval
  • I won't merge this pull request until after the UTC date Sat, 27 Jun 2020 03:49:51 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@Pilchie
Copy link
Member

Pilchie commented Jun 27, 2020

@msftbot please merge in 1 minute

@ghost
Copy link

ghost commented Jun 27, 2020

Hello @Pilchie!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it has at least 1 approval
  • I won't merge this pull request until after the UTC date Sat, 27 Jun 2020 04:16:23 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit d617979 into master Jun 27, 2020
@ghost ghost deleted the smit/cleanuptest branch June 27, 2020 04:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants