Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API review changes #20452

Merged
merged 1 commit into from
Mar 29, 2020
Merged

API review changes #20452

merged 1 commit into from
Mar 29, 2020

Conversation

ajcvickers
Copy link
Member

Issue #20409

  • ValueComparer.HasDefaultBehavior => IsDefault extension method
  • Convert DiagnosticsLoggerExtensions to default interface implementations
  • GetCheckedConnectionString removed from interface and changed to protected GetValidatedConnectionString

@ajcvickers
API review changes
6813c6b 
Issue #20409

* ValueComparer.HasDefaultBehavior => IsDefault extension method
* Convert DiagnosticsLoggerExtensions to default interface implementations
* GetCheckedConnectionString removed from interface and changed to protected GetValidatedConnectionString
@ajcvickers ajcvickers requested a review from a team March 28, 2020 21:58
@ajcvickers ajcvickers merged commit 759375c into master Mar 29, 2020
@ajcvickers ajcvickers deleted the EhPeeEye0328 branch March 29, 2020 14:55
@ajcvickers ajcvickers mentioned this pull request Apr 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

@lajones lajones lajones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajcvickers @smitpatel @lajones