Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.Data.Sqlite: Bring back the SqliteBlob optimizations #20092

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Microsoft.Data.Sqlite: Bring back the SqliteBlob optimizations #20092

merged 1 commit into from
Feb 28, 2020

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Feb 27, 2020 •
edited
Loading

This reverts commits 2fdcc8d and b416e9d.

(Added a few missing using statements in the tests.)

Fixes #13987

@bricelam bricelam changed the title Microsoft.Data.SQLite: Bring back the SqliteBlob optimizations Microsoft.Data.Sqlite: Bring back the SqliteBlob optimizations Feb 27, 2020
@bricelam bricelam marked this pull request as ready for review February 28, 2020 17:45
@bricelam
Copy link
Contributor Author

CI passed every time (3 runs)

@bricelam bricelam merged commit 2fad00e into dotnet:master Feb 28, 2020
@bricelam bricelam deleted the blob2 branch February 28, 2020 20:02
@ajcvickers ajcvickers mentioned this pull request Mar 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Microsoft.Data.Sqlite: Make GetBytes, GetChars, and GetTextReader more efficient
2 participants
@bricelam @ajcvickers