[release/3.1] Fix dotnet-ef RuntimeFrameworkVersion #20007
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dotnet-ef global tool was built incorrectly:
Customer Impact
This will break common VS scenarios as well as people who install the latest tool on the command line.
How found
CTI validation using VS following the patch release, and also customer-reported on the command line.
Test coverage
We have done manual validation on the new PR and will validate again once it is in the build.
Going forward we need to make sure that we can reproduce this in the CTI validation before the new packages are pushed to NuGet.
Also, since we knew about this before and thought it was fixed we will investigate what happened in the process that allowed this.
Regression?
Yes, from 3.0.
Risk
Low.
We had some dead code in the project files: (I'm not exactly sure what happened, but it looks like it broke while migrating to Arcade.)
Fixes errors like:
Verification:
Installed a local 3.1.3 build of dotnet-ef with only runtime 3.1.1 available and it worked where dotnet-ef 3.1.2 failed. Also verified that the runtimeconfig contains 3.1.0 instead of the latest patch version.
Fixes #20005