Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CosmosClientWrapper and SingletonCosmosClientWrapper should be defined by interfaces #19723

Closed
ajcvickers opened this issue Jan 27, 2020 · 0 comments · Fixed by #23508
Closed

CosmosClientWrapper and SingletonCosmosClientWrapper should be defined by interfaces #19723

ajcvickers opened this issue Jan 27, 2020 · 0 comments · Fixed by #23508
Labels
area-cosmos closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
6.0.0

Comments

@ajcvickers
Copy link
Member

Since they are D.I. services they should have a public surface interface which others depend on.
@ajcvickers ajcvickers added this to the Backlog milestone Jan 31, 2020
@ajcvickers ajcvickers modified the milestones: Backlog, MQ Nov 2, 2020
ajcvickers added a commit that referenced this issue Nov 26, 2020
@ajcvickers
Interfaces for CosmosClientWrapper and SingletonCosmosClientWrapper
a6d4865 
Fixes #19723
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 26, 2020
@ajcvickers ajcvickers modified the milestones: MQ, 6.0.0 Nov 26, 2020
@ajcvickers ajcvickers mentioned this issue Nov 26, 2020
Merged
ajcvickers added a commit that referenced this issue Nov 27, 2020
@ajcvickers
Interfaces for CosmosClientWrapper and SingletonCosmosClientWrapper (#…
a819837 
…23508)

Fixes #19723
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-preview1 Jan 27, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview1, 6.0.0 Nov 8, 2021
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-cosmos closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Interfaces for CosmosClientWrapper and SingletonCosmosClientWrapper dotnet/efcore
2 participants
@ajcvickers @AndriySvyryd