This repository has been archived by the owner on Nov 1, 2020. It is now read-only.
ARM64: Add more cfi data #8336
Merged
ARM64: Add more cfi data #8336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the assembler helpers follow the ARM64 ABI and build a correct chain of frame information the debugger still have trouble to show a correct call stack when it include one of these assembler functions. The callstack either stops with with the last of these functions or shows it like it was called recursive It although makes stepping really slow. This fix adds additional cfi data for each frame that the assembler code adds on the stack. With this additional information the debugger can now show a correct callstack.
jkotas
reviewed
Sep 16, 2020
|
The prolog/epilog macros are now all equal between CoreRT and CoreCLR. This should help merging both projects closer together if needed. |
jkotas
reviewed
Sep 17, 2020
| @@ -216,7 +238,7 @@ | |||
|
|
|||
| // x2 = GetThread() | |||
| #ifdef FEATURE_EMULATED_TLS | |||
| GETTHREAD_ETLS_2 | |||
| bl RhpGetThreadETLS2 | |||
There was a problem hiding this comment.
These exception handling methods are not performance critical at all. It would be fine to always call RhpGetThread directly from here, for both FEATURE_EMULATED_TLS and !FEATURE_EMULATED_TLS, without going through the multiple levels of macros and wrappers.
Note that callee saved registers are saved by ALLOC_THROW_FRAME. You can stash the arguments in one of them around the call.
There was a problem hiding this comment.
This can be separate change. The multiple levels of macros are not that bad yet.
jkotas
approved these changes
Sep 17, 2020
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the assembler helpers follow the ARM64 ABI and build a correct chain of frame information the debugger still have trouble to show a correct call stack when it include one of these assembler functions. The callstack either stops with with the last of these functions or shows it like it was called recursive It although makes stepping really slow.
This fix adds additional cfi data based on the same prolog/epilog macros from CoreCLR. With this additional information the debugger can now show a correct callstack.
The modified macros caused some adjustments.