Don't fall through endfinally and others #2560
Conversation
| @@ -66,9 +66,6 @@ private void InitLibraryInitializers() | |||
|
|
|||
| foreach (var entry in s_assembliesWithLibraryInitializers) | |||
| { | |||
| if (_isCppCodeGen && !entry.UseWithCppCodeGen) | |||
There was a problem hiding this comment.
Could please clear the flag isCppCodeGen flag here, and delete link to the fixed issues here instead?
I think the flag to filter based on isCppCodeGen can stay around; even though it is unused right now. We will likely want different implementations of some parts for it eventually; or it may be useful to workaround CppCodeGen bugs.
|
Thank you for the fix! |
endfinally, endfilter and rethrow were treated as fallthrough capable when they are not. endfinally was also failing to clear the stack.
|
Updated, hope I got it right. Out of curiosity: what's the plan for exception handling in CPP codegen? EH isn't exactly trivial even in native codegen, in CPP codegen it's probably even more problematic. |
Piggy back on C++ exception handling, use explicit checks instead of hardware exceptions (e.g. explicit checks for null reference exceptions). Unity IP2CPP internals blog shows example of possible way to do this. Mono LLVM pure bitcode backend has same problem and it uses similar scheme to solve it. |
|
Mentioned the same in #910 |
endfinally,endfilterandrethrowwere treated as fallthrough capable when they are not.endfinallywas also failing to clear the stack.Fixes #2518