[release/8.1] Enable full signing and stable package versions #4989
Conversation
dotnet-issue-labeler
bot
added
the
needs-area-label
| @@ -6,6 +6,8 @@ | |||
| <PackageTags>aspire hosting azure webpubsub pubsub websocket</PackageTags> | |||
| <Description>Azure WebPubSub resource types for .NET Aspire.</Description> | |||
| <PackageIconFullPath>$(SharedDir)AzureWebPubSub_256x.png</PackageIconFullPath> | |||
| <!-- This library can't ship stable until Azure.Provisioning.WebPubSub ships stable. --> | |||
| <SuppressFinalPackageVersion>true</SuppressFinalPackageVersion> | |||
|
Is this branch meant for |
|
Ohh great catch, yes retargeting. |
|
/azp run dotnet.aspire |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>$(NetCurrent)</TargetFramework> | |||
| <ProductVersion>8.1.0</ProductVersion> | |||
There was a problem hiding this comment.
Why do we need to hard code this? Why can't it be generated from the other MSBuild properties?
There was a problem hiding this comment.
I tried locally using major and minor version but I think this project didn't import the right props and due to timing just wanted to unblock the build. End to End tests are failing now, so I guess now I have to fix than anyway.
There was a problem hiding this comment.
Looks like there are several assumptions that the testing infrastructure makes around package versions which may not be correct as they assume that the same package version will be used everywhere, which will certainly not always be the case. I just spent some time trying to fix another package testing issue I was seeing, but couldn't get the versions to flow correctly so due to time I just pushed another change which hardcodes the versions for now to unblock the build and be able to get a build out for validation. We should of course undo these hard coded hacks, but we should also fix these assumptions on versions. cc: @radical
There was a problem hiding this comment.
Do we have an issue tracking this to fix it in main?
|
@joperezr - Are you going to forward port any relevant changes here to |
|
After release, we always merge back the release branch into main in order to make sure that changes that were done are not missed. |
Getting ready for 8.1 release.
Microsoft Reviewers: Open in CodeFlow